Re: [PATCH] staging:iio:light: Add some missing brackets to make sure code works as intended. Note this is not a bug due to the fact the region cannot be reached without the sanity check passing. The autobuilder reported it as missaligned code which is kind of true as well.

[Daniel Baluta <daniel.baluta@xxxxxxxxx>]

This looks good to me. Anyhow, we need a newline somewhere in the
commit subject.

On Sat, May 2, 2015 at 2:05 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Roberta Dobrescu <roberta.dobrescu@xxxxxxxxx>
> ---
>  drivers/staging/iio/light/isl29018.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index 08ca9a4172e3..e646c5d24004 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -369,12 +369,13 @@ static int isl29018_write_raw(struct iio_dev *indio_dev,
>                 }
>                 break;
>         case IIO_CHAN_INFO_INT_TIME:
> -               if (chan->type == IIO_LIGHT)
> +               if (chan->type == IIO_LIGHT) {
>                         if (val != 0) {
>                                 mutex_unlock(&chip->lock);
>                                 return -EINVAL;
>                         }
>                         ret = isl29018_set_integration_time(chip, val2);
> +               }
>                 break;
>         case IIO_CHAN_INFO_SCALE:
>                 if (chan->type == IIO_LIGHT)
> --
> 2.3.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html