On 27/04/15 17:03, Rhyland Klein wrote: > On 4/26/2015 3:51 PM, Jonathan Cameron wrote: >> On 16/04/15 20:20, Roberta Dobrescu wrote: >>> This patch refactors the isl29018 driver code in order to use standard >>> sysfs attributes for scale and integration time. >>> >>> ISL29018 light sensor uses four ranges and four ADC's resolutions >>> which influence the calculated lux. Adc resolution is strongly >>> connected to integration time and range should be controlled by scale. >>> >>> This patch introduces the usage of integration time and scale instead >>> of adc resolution and range. >>> >>> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@xxxxxxxxx> >> Looks good to me, Applied to the togreg branch of iio.git - initially pushed out >> as testing. >> >> cc'd Rhyland though not heard from him for quite a while. >> >> Rhyland, if you are still interested in this driver, give me a shout and I can >> hold these patches back until you get a chance to look at them. >> >> Sorry, forgot to cc you earlier in the discussion! >> >> Jonathan >> > > Its fine, don't hold up patches on my account. I haven't looked at this > in a while, so don't gate on me :) > > -rhyland I missed a small issue with some missing brackets in one of the switch statements. The autobuilder caught it as a formatting issue: drivers/staging/iio/light/isl29018.c:373:3-4: code aligned with following code on line 377. I'll send out a patch in a mo, but as it's trivial am happy to apply it without an ack. note this isn't actually a bug due to the check being strictly unnecessary anyway, but it is clearly not as intended! Jonathan > > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
