Re: [PATCH 2/2] iio: light: ltr501: Powerdown device on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mi, 2015-04-01 at 14:46 +0300, Daniel Baluta wrote:
> On Wed, Apr 1, 2015 at 2:01 PM, Cristina Opriceana
> <cristina.opriceana@xxxxxxxxx> wrote:
> > Power down device when an error occurs  in order to avoid wasting
> > power. Also move powerdown function up to be seen by the new call.
> >
> > Signed-off-by: Cristina Opriceana <cristina.opriceana@xxxxxxxxx>
> > ---
> >  drivers/iio/light/ltr501.c | 18 ++++++++++--------
> >  1 file changed, 10 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
> > index 62b7072..29ca4b8 100644
> > --- a/drivers/iio/light/ltr501.c
> > +++ b/drivers/iio/light/ltr501.c
> > @@ -333,6 +333,13 @@ static int ltr501_init(struct ltr501_data *data)
> >                 data->ps_contr);
> >  }
> >
> > +static int ltr501_powerdown(struct ltr501_data *data)
> > +{
> > +       return ltr501_write_contr(data->client,
> > +               data->als_contr & ~LTR501_CONTR_ACTIVE,
> > +               data->ps_contr & ~LTR501_CONTR_ACTIVE);
> > +}
> > +
> 
> While at it please also fix the alignment for ltr501_write_contr
> parameters. Don't forget
> to mention this in the commit message. When running checkpatch.pl
> please use --strict parameter.
> 
> thanks,
> Daniel.

Another patch would be fine or should I send a v2?

Cristina


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux