On Mon, Mar 16, 2015 at 1:48 PM, Darshana Padmadas <darshanapadmadas@xxxxxxxxx> wrote: > This patchset adds ABI documentation for the following attributes: > > in_illuminance_scale, used atleast once in al3320a staging/iio/light/ Reference to staging/iio/light here is confusing. People might think that al3320 is in staging, while staging is your source tree top directory. Better drop it :). Also s/atleast/at least/ Just say: in_illuminance_scale, exported by al3320a ambient light sensor. > in_illuminance_calibscale, used atleast once in cm32181 > in_illuminance_input, used in cm3232 at least once > in_illuminance_raw used atleast once in al3320a > in_illuminance_clear_raw and in_illuminance_ir_raw exposed by > gp2ap020a00f with modifiers IIO_MOD_LIGHT_CLEAR and > IIO_MOD_LIGHT_IR respectively. The same for all the above. Other than that, the patch looks good to me. Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html