On 03/03/15 16:17, Octavian Purdila wrote:
> From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@xxxxxxxxx>
>
> Currently driver reports device bandwidth list as available
> sampling frequency. But sampling frequency is actually twice
> the device bandwidth. This patch fixes this issue.
>
> Signed-off-by: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@xxxxxxxxx>
I was going to reject this on the basis that it should be using the
low_pass_filter_3db_bandwidth rather than sampling frequency but in
this device the two are tied together in a fashion not often seen.
Anyhow, fair enough.
It's probably going to make life messy with the rest of the series, but this
is clearly a fix that wants to stable as well.
Note Octavian that as you handled the patch it ought to have your sign off
as well as Sathyanarayanan's.
Jonathan
> ---
> drivers/iio/accel/bmc150-accel.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
> index 8004ce3..74ee54e 100644
> --- a/drivers/iio/accel/bmc150-accel.c
> +++ b/drivers/iio/accel/bmc150-accel.c
> @@ -168,14 +168,14 @@ static const struct {
> int val;
> int val2;
> u8 bw_bits;
> -} bmc150_accel_samp_freq_table[] = { {7, 810000, 0x08},
> - {15, 630000, 0x09},
> - {31, 250000, 0x0A},
> - {62, 500000, 0x0B},
> - {125, 0, 0x0C},
> - {250, 0, 0x0D},
> - {500, 0, 0x0E},
> - {1000, 0, 0x0F} };
> +} bmc150_accel_samp_freq_table[] = { {15, 620000, 0x08},
> + {31, 260000, 0x09},
> + {62, 500000, 0x0A},
> + {125, 0, 0x0B},
> + {250, 0, 0x0C},
> + {500, 0, 0x0D},
> + {1000, 0, 0x0E},
> + {2000, 0, 0x0F} };
>
> static const struct {
> int bw_bits;
> @@ -783,7 +783,7 @@ static int bmc150_accel_validate_trigger(struct iio_dev *indio_dev,
> }
>
> static IIO_CONST_ATTR_SAMP_FREQ_AVAIL(
> - "7.810000 15.630000 31.250000 62.500000 125 250 500 1000");
> + "15.620000 31.260000 62.50000 125 250 500 1000 2000");
>
> static struct attribute *bmc150_accel_attributes[] = {
> &iio_const_attr_sampling_frequency_available.dev_attr.attr,
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
