On 03/03/15 07:58, Markus Pargmann wrote: > The documentation describes the bindings for the imx25 GCQ unit which is > essentially a generic conversion queue using the imx25 ADC. > > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx> Looks good to me, though ideally these would get a devicetree maintainer ack. Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx> > --- > > Notes: > Changes in v6: > - Changed bindings to use adc-refp and adc-refn. Also a bit of cleanup in the > setup routine. > > Changes in v5: > - Fixed locking > - Removed module owner > > .../devicetree/bindings/iio/adc/fsl,imx25-gcq.txt | 54 ++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.txt b/Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.txt > new file mode 100644 > index 000000000000..9f7c08990034 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.txt > @@ -0,0 +1,54 @@ > +Freescale i.MX25 ADC GCQ device > + > +This is a generic conversion queue device that can convert any of the > +analog inputs using the ADC unit of the i.MX25. > + > +Required properties: > + - compatible: Should be "fsl,imx25-gcq". > + - reg: Should be the register range of the module. > + - interrupts: Should be the interrupt number of the module. > + Typically this is <1>. > + - interrupt-parent: phandle to the tsadc module of the i.MX25. > + - #address-cells: Should be <1> (setting for the subnodes) > + - #size-cells: Should be <0> (setting for the subnodes) > + > +Optional properties: > + - vref-supply: The regulator supplying the ADC reference voltage. > + Required when at least one subnode uses the external reference. > + > +Sub-nodes: > +Optionally you can define subnodes which define the reference voltage > +for the analog inputs. > + > +Required properties for subnodes: > + - reg: Should be the number of the analog input. > + 0: xp > + 1: yp > + 2: xn > + 3: yn > + 4: wiper > + 5: inaux0 > + 6: inaux1 > + 7: inaux2 > +Optional properties for subnodes: > + - fsl,adc-refp: specifies the positive reference input as defined in > + <dt-bindings/iio/adc/fsl-imx25-gcq.h> > + - fsl,adc-refn: specifies the negative reference input as defined in > + <dt-bindings/iio/adc/fsl-imx25-gcq.h> > + > +Example: > + > + adc: adc@50030800 { > + compatible = "fsl,imx25-gcq"; > + reg = <0x50030800 0x60>; > + interrupt-parent = <&tscadc>; > + interrupts = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + inaux@5 { > + reg = <5>; > + fsl,adc-refp = <MX25_ADC_REF_INT>; > + fsl,adc-refn = <MX25_ADC_REF_NGND>; > + }; > + }; > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html