On 03/06/2015 09:58 AM, Daniel Baluta wrote:
Hi Somya,
On Fri, Mar 6, 2015 at 10:36 AM, Somya Anand <somyaanand214@xxxxxxxxx> wrote:
In the adis16220_read16bit() function we earlier used a s16 value 'val'
which is used by the adis_read_reg_16 function to read data and takes a
u16 value as a parameter.
So, this patch changes the data type of 'val' from s16 to u16 for further
simplification of code and thereby avoiding unnecessary typecast.
Signed-off-by: Somya Anand <somyaanand214@xxxxxxxxx>
Patch looks ok. But it changes the semantics of the function, the reason why
this is a s16 instead of a u16 is because at some point the function was
used to read register that contained signed 16 bit values. The code is
essentially the short version of:
u16 uval;
adis_read_reg_16(&st->adis, this_attr->address, &uval);
sprintf("%d\n", sign_extend32(uval, 15));
This patch removes the extra sign extension. Which is ok, since the only
user of the function uses it to read a 10 unsigned value which will lead to
the same result in both cases. But the commit message should mention this,
since it is not just the removal of a unnecessary type cast.
- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
