On January 21, 2015 19:26, Peter Meerwald wrote:
> > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC.
> >
> > Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
> > Reviewed-by: Hartmut Knaack <knaack.h@xxxxxx>
> > Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx>
>
> minor nitpicking (formatting) below
> > +/* Private data */
> > +struct da9150_gpadc {
> > + struct da9150 *da9150;
> > + struct device *dev;
> > +
> > + struct mutex lock;
> > + struct completion complete;
> > +};
> > +
>
> extra newline
Have subsequent modules to submit, so when I do that I'll also fix these minor
formatting discrepancies.
>
> > +
> > +static irqreturn_t da9150_gpadc_irq(int irq, void *data)
> > +{
> > +
>
> extra newline
>
Noted.
> > +static const struct iio_info da9150_gpadc_info = {
> > + .read_raw = &da9150_gpadc_read_raw,
> > + .driver_module = THIS_MODULE,
> > +};
> > +
> > +#define DA9150_GPADC_CHANNEL(_id, _hw_id, _type, chan_info, \
>
> all macro parameters have a _ prefix except chan_info
>
Noted.
��.n��������+%������w��{.n�����{��(��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
