On 02/18/2015 11:47 AM, Geert Uytterhoeven wrote:
> If CONFIG_PM_SLEEP=n:
>
> drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used
> drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used
>
> Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> drivers/iio/common/ssp_sensors/ssp_dev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
> index 52d70435f5a11c55..55a90082a29bd484 100644
> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
> @@ -640,6 +640,7 @@ static int ssp_remove(struct spi_device *spi)
> return 0;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> static int ssp_suspend(struct device *dev)
> {
> int ret;
> @@ -688,6 +689,7 @@ static int ssp_resume(struct device *dev)
>
> return 0;
> }
> +#endif /* CONFIG_PM_SLEEP */
>
> static const struct dev_pm_ops ssp_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume)
>
Patch is ok but commit title points to different driver. Irina would be
surprised and confused to see it on the list and log.
Please, use something like that: iio: common: ssp_sensors: Fix warnings ...
Thanks,
Karol
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
