Re: [PATCH v3 4/9] iio: bmc150: refactor slope duration and threshold update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 8, 2015 at 12:37 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On 05/02/15 17:02, Srinivas Pandruvada wrote:
>> On Sat, 2015-01-31 at 02:00 +0200, Octavian Purdila wrote:
>>> Move the slope duration and threshold update in a separate function to
>>> reduce code duplicate between chip init and motion interrupt setup.
>>>
>>> Also move the slope update code from the interrupt setup function to
>>> the trigger set state function so that we can later refactor the
>>> interrupt code.
>>>
>>> Signed-off-by: Octavian Purdila <octavian.purdila@xxxxxxxxx>
>> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> My only comment here is that I'd have preferred this being in a separate precursor
> series as it's not really connected to the hardware buffer stuff!
> Keep your series focused and if there is refactoring to be done, please
> do it first.
>

I will keep that in mind for the future and sorry for the trouble.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux