On Wednesday 21 January 2015 03:44 PM, Vignesh R wrote: > On Tuesday 20 January 2015 09:34 PM, Lee Jones wrote: >> On Tue, 20 Jan 2015, R, Vignesh wrote: >>> On 1/20/2015 5:23 PM, Lee Jones wrote: >>>> On Wed, 07 Jan 2015, Vignesh R wrote: >>>> >>>>> In one shot mode, sequencer automatically disables all enabled steps at >>>>> the end of each cycle. (both ADC steps and TSC steps) Hence these steps >>>>> need not be saved in reg_se_cache for clearing these steps at a later >>>>> stage. >>>>> Also, when ADC wakes up Sequencer should not be busy executing any of the >>>>> config steps except for the charge step. Previously charge step was 1 ADC >>>>> clock cycle and hence it was ignored. >>>>> TSC steps are always disabled at the end of each conversion cycle, hence >>>>> there is no need to explicitly disable TSC steps by writing 0 to REG_SE. >>>>> >>>>> Signed-off-by: Vignesh R <vigneshr@xxxxxx> >>>>> --- >>>>> >>>>> v5: >>>>> - Remove unnecessary clearing of REG_SE >>>>> >>>>> drivers/mfd/ti_am335x_tscadc.c | 13 +++++-------- >>>>> include/linux/mfd/ti_am335x_tscadc.h | 1 + >>>>> 2 files changed, 6 insertions(+), 8 deletions(-) >>>> >>>> Looks fine. >>>> >>>> For my own reference: >>>> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> >>>> >>>> Can this patch be applied on its own? >>>> >>> >>> I prefer to wait until input patches are picked up. >> >> I have no problem with that, but is there a technical reason why? >> > > Nothing, in particular. This patch alone has no impact on the > performance of TSC/ADC unit. Patch 2/6 is necessary to observe the > changes caused by this series. Hence, please wait until those patches > are picked up. Input maintainer has applied other patches. You can pick this one. Regards Vignesh R -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
