Re: [PATCH v3 2/9] iio: add watermark logic to iio read and poll

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 4, 2015 at 8:49 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On 31/01/15 00:00, Octavian Purdila wrote:
>> From: Josselin Costanzi <josselin.costanzi@xxxxxxxxxxxxxxxxx>
>>
>> Currently the IIO buffer blocking read only wait until at least one
>> data element is available.
>> This patch makes the reader sleep until enough data is collected before
>> returning to userspace. This should limit the read() calls count when
>> trying to get data in batches.
>>
>> Co-author: Yannick Bedhomme <yannick.bedhomme@xxxxxxxxxxxxxxxxx>
>> Signed-off-by: Josselin Costanzi <josselin.costanzi@xxxxxxxxxxxxxxxxx>
>> [rebased and remove buffer timeout]
>> Signed-off-by: Octavian Purdila <octavian.purdila@xxxxxxxxx>
> One question on the ABI below... Otherwise looks good to me.
>
>> ---
>>  Documentation/ABI/testing/sysfs-bus-iio  |  10 +++
>>  drivers/iio/industrialio-buffer.c        | 124 ++++++++++++++++++++++++++-----
>>  drivers/iio/kfifo_buf.c                  |  11 +--
>>  drivers/staging/iio/accel/sca3000_ring.c |   4 +-
>>  include/linux/iio/buffer.h               |   8 +-
>>  5 files changed, 127 insertions(+), 30 deletions(-)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>> index c03a140..2a3dc12 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>> @@ -1193,3 +1193,13 @@ Description:
>>               This attribute is used to read the current speed value of the
>>               user (which is the norm or magnitude of the velocity vector).
>>               Units after application of scale are m/s.
>> +
>> +What:                /sys/bus/iio/devices/iio:deviceX/buffer/low_watermark
> Just thinking about this again.  Why low?

I just kept the original name. A simple watermark sounds better to me,
I will change it in the next version.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux