Re: [PATCH v2] iio: ensure scan index is unique at buffer register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/12/14 16:31, Lars-Peter Clausen wrote:
> On 12/12/2014 03:26 PM, Vlad Dogaru wrote:
>> Having two or more channels with the same positive scan_index field
>> makes no sense.  Prevent this situation by failing to register a buffer
>> if two scan indexes are identical.
>>
>> Signed-off-by: Vlad Dogaru <vlad.dogaru@xxxxxxxxx>
> 
> Looks ok, although I'm not convinced that we really need it.
> 
> Reviewed-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> 
> [...]
I'm kind of mildly in favour of things that make bugs
less likely.  However, I think this fell foul of Lars'
recent set of cleanups for the buffered code.

Could you rebase on my togreg branch.
https://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/log/?h=togreg

Thanks

Jonathan

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux