Re: [PATCH 3/3] iio: frequency: Use usleep_range instead of msleep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/16/2014 10:11 AM, Roberta Dobrescu wrote:
This patch fixes the following checkpatch.pl warning:
WARNING: msleep < 20ms can sleep for up to 20ms

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@xxxxxxxxx>
---
  drivers/iio/frequency/ad9523.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
index 7c5245d..2e41ca5 100644
--- a/drivers/iio/frequency/ad9523.c
+++ b/drivers/iio/frequency/ad9523.c
@@ -445,7 +445,7 @@ static int ad9523_store_eeprom(struct iio_dev *indio_dev)

  	tmp = 4;
  	do {
-		msleep(16);
+		usleep_range(16000, 17000);

I don't think this is exactly timing critical, things will work fine if this sleeps a bit longer. If you want to silence the warning for the sake of silencing the warning, maybe just replace it with a msleep(20).

  		ret = ad9523_read(indio_dev,
  				  AD9523_EEPROM_DATA_XFER_STATUS);
  		if (ret < 0)


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux