Re: [PATCH] bmp280: use correct routine for division

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 23, 2014 at 4:08 PM, Vlad Dogaru <vlad.dogaru@xxxxxxxxx> wrote:
> The proper way to divide two signed 64-bit values is to use div4_s64.

s/div4_s64/div64_s64

Otherwise, it looks good to me. Thanks Vlad!

>
> Signed-off-by: Vlad Dogaru <vlad.dogaru@xxxxxxxxx>
> ---
>  drivers/iio/pressure/bmp280.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/pressure/bmp280.c b/drivers/iio/pressure/bmp280.c
> index fb91cb3..ce29ff9 100644
> --- a/drivers/iio/pressure/bmp280.c
> +++ b/drivers/iio/pressure/bmp280.c
> @@ -239,7 +239,7 @@ static u32 bmp280_compensate_press(struct bmp280_data *data,
>                 return 0;
>
>         p = ((((s64) 1048576 - adc_press) << 31) - var2) * 3125;
> -       do_div(p, var1);
> +       p = div64_s64(p, var1);
>         var1 = (((s64) comp->dig_p9) * (p >> 13) * (p >> 13)) >> 25;
>         var2 = (((s64) comp->dig_p8) * p) >> 19;
>         p = ((p + var1 + var2) >> 8) + (((s64) comp->dig_p7) << 4);
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux