Please let me know your review comments. PATCH v6 changes: Addressed comments from Peter & Hartmut. Mainly, 1. Removed duplicate header files 2. Renamed IRDR settings macro names 3. Simplified endian conversion expression 4. Refactored the code in many sections to remove unncessary breaks statements and returns. 5. Renamed jsa1212 priv data variable name in probe function. PATCH v5 changes: 1. Removed irq.h and interrupt.h. 2. Disabled the device under error condition when reading data. 3. Added TODO and slave address info in file header. PATCH v4 changes: 1. Removed unused register defines 2. Used standard endian conversion function instead of custom one. 3. Replaced register default value constants with appropriate bit value macros. 4. Removed iio user interfaces before powering off the device in remove function. PATCH v3 changes: 1. Replaced status flags with bool values. 2. Added regmap suppport to avoid adding custom i2c register update routine. 3. Also addressed some minor comments from Jonathan Cameron PATCH v2 changes: 1. Combined ALS/PXS enable/disable functions into a single routine. 2. Removed extra debug messages. 3. Also addressed review comments from Peter Meerwald Kuppuswamy Sathyanarayanan (1): iio: jsa1212: Add JSA1212 proximity/ALS sensor drivers/iio/light/Kconfig | 10 + drivers/iio/light/Makefile | 1 + drivers/iio/light/jsa1212.c | 470 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 481 insertions(+) create mode 100644 drivers/iio/light/jsa1212.c -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
