Re: [PATCH 25/27] staging:iio:mxs-lradc: Use iio_push_to_buffers_with_timestamp()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Lars-Peter Clausen,

> On 09/16/2013 03:53 PM, Marek Vasut wrote:
> > Dear Lars-Peter Clausen,
> > 
> >> Makes the code a bit shorter and less ugly.
> >> 
> >> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> >> Cc: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> >> Cc: Marek Vasut <marex@xxxxxxx>
> >> ---
> >> 
> >>  drivers/staging/iio/adc/mxs-lradc.c | 8 +-------
> >>  1 file changed, 1 insertion(+), 7 deletions(-)
> >> 
> >> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
> >> b/drivers/staging/iio/adc/mxs-lradc.c index 7401230..9da64bf 100644
> >> --- a/drivers/staging/iio/adc/mxs-lradc.c
> >> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> >> @@ -625,13 +625,7 @@ static irqreturn_t mxs_lradc_trigger_handler(int
> >> irq, void *p) j++;
> >> 
> >>  	}
> >> 
> >> -	if (iio->scan_timestamp) {
> >> -		s64 *timestamp = (s64 *)((u8 *)lradc->buffer +
> >> -					ALIGN(j, sizeof(s64)));
> >> -		*timestamp = pf->timestamp;
> >> -	}
> >> -
> >> -	iio_push_to_buffers(iio, lradc->buffer);
> >> +	iio_push_to_buffers_with_timestamp(iio, lradc->buffer, pf->timestamp);
> >> 
> >>  	iio_trigger_notify_done(iio->trig);
> > 
> > Indeed, this stuff was duplicated all around.
> 
> Is that a acked-by? :)

Reviewed-by: Marek Vasut <marex@xxxxxxx>

instead. I'm not on too firm ground here, so I don't feel like ack is 
appropriate from me on this matter ;-)

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux