On 01/20/2013 01:32 PM, Peter Meerwald wrote: > Hello, > >> This driver is simple, uses the latest interfaces and contains few if >> any controversial elements. All of its interfaces have been in place >> for a long time now. Hence let's move it out of staging. > > two small nitpicks inline > Thanks! > regards, p. ... >> obj-$(CONFIG_ADJD_S311) += adjd_s311.o >> obj-$(CONFIG_SENSORS_LM3533) += lm3533-als.o >> +obj-$(CONFIG_SENSORS_TSL2563) += tsl2563.o > > there is the SENSORS_ prefix which is an inconsistency; there were some > arguments against it... Hmm. I was holding off on this purely as it might break things. It's used in one of the omap board files for starters. Tony, what are your views on cleaning this up? It's in arch/arm/mach-omap2/board-rx51-peripherals.c. There presumably isn't really a problem in a patch fixing this end going via IIO and another to change the ifdef via your tree? At somepoint the support won't be enabled but it won't cause any problems. There is still a bit of debate on whether an IIO prefix makes sense or if such prefixes should be dropped entirely so we end up with CONFIG_TSL2563... > >> obj-$(CONFIG_VCNL4000) += vcnl4000.o >> obj-$(CONFIG_HID_SENSOR_ALS) += hid-sensor-als.o >> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c >> new file mode 100644 >> index 0000000..86bcadc >> --- /dev/null >> +++ b/drivers/iio/light/tsl2563.c >> @@ -0,0 +1,887 @@ >> +/* >> + * drivers/i2c/chips/tsl2563.c > > this should be drivers/iio/light/tsl2563.c > Good spot, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
