Re: [PATCH 3/4] iio: Don't compare boolean values to true/false

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/18/2012 03:43 PM, Lars-Peter Clausen wrote:
> Fixes the following warnings from coccicheck:
> 	drivers/iio/inkern.c:81:6-14: WARNING: Comparison to bool
> 	drivers/iio/dac/ad5686.c:191:5-11: WARNING: Comparison to bool
> 
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Another 'exciting patch'.  I guess it fills the time whilst on a train
under the sea though... hohum.  Land soon and back to mindless websurfing...
> ---
>  drivers/iio/dac/ad5686.c |    2 +-
>  drivers/iio/inkern.c     |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
> index 6948d75..bc92ff9 100644
> --- a/drivers/iio/dac/ad5686.c
> +++ b/drivers/iio/dac/ad5686.c
> @@ -188,7 +188,7 @@ static ssize_t ad5686_write_dac_powerdown(struct iio_dev *indio_dev,
>  	if (ret)
>  		return ret;
>  
> -	if (readin == true)
> +	if (readin)
>  		st->pwr_down_mask |= (0x3 << (chan->channel * 2));
>  	else
>  		st->pwr_down_mask &= ~(0x3 << (chan->channel * 2));
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index f2b78d4..5230a33 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -78,7 +78,7 @@ int iio_map_array_unregister(struct iio_dev *indio_dev,
>  				found_it = true;
>  				break;
>  			}
> -		if (found_it == false) {
> +		if (!found_it) {
>  			ret = -ENODEV;
>  			goto error_ret;
>  		}
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux