Re: [PATCH 1/3] staging:iio:dac:ad5504: Use strtobool for boolean values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/15/2012 8:52 AM, Lars-Peter Clausen wrote:
Use strtobool for parsing the powerdown value instead of strict_strtol, since
the powerdown attribute is a boolean value.

Signed-off-by: Lars-Peter Clausen<lars@xxxxxxxxxx>
Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx>
---
  drivers/staging/iio/dac/ad5504.c |   10 ++++------
  1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/iio/dac/ad5504.c b/drivers/staging/iio/dac/ad5504.c
index 25a04d3..6ccf178 100644
--- a/drivers/staging/iio/dac/ad5504.c
+++ b/drivers/staging/iio/dac/ad5504.c
@@ -147,20 +147,18 @@ static ssize_t ad5504_write_dac_powerdown(struct iio_dev *indio_dev,
  	uintptr_t private, const struct iio_chan_spec *chan, const char *buf,
  	size_t len)
  {
-	long readin;
+	bool pwr_down;
  	int ret;
  	struct ad5504_state *st = iio_priv(indio_dev);

-	ret = strict_strtol(buf, 10,&readin);
+	ret = strtobool(buf,&pwr_down);
  	if (ret)
  		return ret;

-	if (readin == 0)
+	if (pwr_down)
  		st->pwr_down_mask |= (1<<  chan->channel);
-	else if (readin == 1)
-		st->pwr_down_mask&= ~(1<<  chan->channel);
  	else
-		ret = -EINVAL;
+		st->pwr_down_mask&= ~(1<<  chan->channel);

  	ret = ad5504_spi_write(st->spi, AD5504_ADDR_CTRL,
  				AD5504_DAC_PWRDWN_MODE(st->pwr_down_mode) |

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux