In line.. -----Original Message----- From: Jonathan Cameron [mailto:jic23@xxxxxxxxxx] Sent: Friday, May 11, 2012 2:49 AM To: Jonathan Cameron Cc: Jon Brenner; linux-iio; Alan Cox; samu.p.onkalo@xxxxxxxxx; daniel@xxxxxxxx; giometti@xxxxxxxx; khali@xxxxxxxxxxxx; amit.kucheria@xxxxxxxxxxxxx; Laxman Dewangan; Greg Kroah-Hartman Subject: Re: [PATCH V1] RFC - Proposed IIO Documentation patch to add CCT and RGBC data On 5/2/2012 9:39 AM, Jonathan Cameron wrote: > Added cc's > > Jon, remember to wrap emails at 80 chars please! >> Request for Comments - >> >> Documentation patch to add Correlated Color Temperature (CCT) and >> RGBC >> (red/green/blue/clear) data. >> >> The addition of CCT and RGBC is afforded by utilizing a 'real channel' >> type of IIO_CCT, and 4 modifiers of IIO_MOD_LIGHT_CLEAR, >> IIO_MOD_LIGHT_RED, IIO_MOD_LIGHT_GREEN, and IIO_MOD_LIGHT_BLUE, found >> in types.h. If we were to apply this to the existing sensors, how do we distinguish between 'clear' vs the visable+infrared option that is there already? I note below that you have distinguished this by saying it is on a colour sensor only. That seems a little bit inconsistent given a single wide band sensor might be measuring the same thing... I'm fine with the colour ones btw but one query below.. >> A trivial addition to industrialio-core.c is required. >> >> in_cct0_input will return typically return the color temperature >> expressed in kelvins. >> >> IIO_MODIFIERs are respective of the associated light frequencies for >> each of the channels. >> >> >> >> >> >> >> Signed-off-by: Jon Brenner<jbrenner@xxxxxxxxxxx> >> --- >> .../staging/iio/Documentation/sysfs-bus-iio-light | 46 >> ++++++++++++++++++++ >> 1 files changed, 46 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/staging/iio/Documentation/sysfs-bus-iio-light >> b/drivers/staging/iio/Documentation/sysfs-bus-iio-light >> index 715c74d..bd42baf 100644 >> --- a/drivers/staging/iio/Documentation/sysfs-bus-iio-light >> +++ b/drivers/staging/iio/Documentation/sysfs-bus-iio-light >> @@ -34,6 +34,15 @@ Description: >> it comes back in SI units, it should also include _input else it >> should include _raw to signify it is not in SI units. >> >> +What: /sys/bus/iio/devices/device[n]/in_cct0[_input|_raw] >> +KernelVersion: 3.4.0 >> +Contact: linux-iio@xxxxxxxxxxxxxxx >> +Description: >> + This should return the correlated color temperature from the light >> +sensor. If it comes back in SI units, it should also include _input >> +else it should include _raw to signify it is not in SI units. >> + >> What: >> /sys/.../device[n]/proximity_on_chip_ambient_infrared_supression >> KernelVersion: 2.6.37 >> Contact: linux-iio@xxxxxxxxxxxxxxx >> @@ -82,3 +91,40 @@ Contact: linux-iio@xxxxxxxxxxxxxxx >> Description: >> This property gets/sets the table of coefficients used in calculating >> illuminance in lux. >> + >> +What: /sys/bus/iio/devices/device[n]/in_intensity_clear[_input|_raw] >> +KernelVersion: 3.4.0 >> +Contact: linux-iio@xxxxxxxxxxxxxxx >> +Description: >> + This property is supported by sensors that have a RGBC sensing >> +mode. This value should be the output from a reading and if >> +expressed in SI units, should include _input. If this value is not >> +in SI units, then it should include _raw. >> + >> +What: /sys/bus/iio/devices/device[n]/in_intensity_red[_input|_raw] >> +KernelVersion: 3.4.0 >> +Contact: linux-iio@xxxxxxxxxxxxxxx >> +Description: >> + This property is supported by sensors that have a RGBC sensing >> +mode. This value should be the output from a reading and if >> +expressed in SI units, should include _input. If this value is not >> +in SI units, then it should include _raw. Err. What are the SI units of intensity? irradiance ie. uW/sq Mil. >> + >> +What: /sys/bus/iio/devices/device[n]/in_intensity_green[_input|_raw] >> +KernelVersion: 3.4.0 >> +Contact: linux-iio@xxxxxxxxxxxxxxx >> +Description: >> + This property is supported by sensors that have a RGBC sensing >> +mode. This value should be the output from a reading and if >> +expressed in SI units, should include _input. If this value is not >> +in SI units, then it should include _raw. >> + >> +What: /sys/bus/iio/devices/device[n]/in_intensity_blue[_input|_raw] >> +KernelVersion: 3.4.0 >> +Contact: linux-iio@xxxxxxxxxxxxxxx >> +Description: >> + This property is supported by sensors that have a RGBC sensing >> +mode. This value should be the output from a reading and if >> +expressed in SI units, should include _input. If this value is not >> +in SI units, then it should include _raw. >> + >> -- >> 1.7.4.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" >> in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo >> info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > info at http://vger.kernel.org/majordomo-info.html ��.n��������+%������w��{.n�����{��(��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥