On 05/10/2012 11:08 AM, Jonathan Cameron wrote:
On 5/9/2012 11:36 AM, michael.hennerich@xxxxxxxxxx wrote:
From: Michael Hennerich<michael.hennerich@xxxxxxxxxx>
Changes since V1:
Apply review feedback:
Introduce and use IIO_CHAN_INFO_HARDWAREGAIN
Introduce and use Use IIO_VAL_INT_PLUS_MICRO_DB
Modify out of staging include paths.
Convert to new iio core API naming.
For reasons I don't understand thunderbird on windows (yes I'm doing
this whilst waiting for something to run at the day job), is wrecking
spacing in subtle ways despite being in plain text mode... Grr.
Anyhow, my only real comment is that I think we may want a little more
value sanity checking in the write_raw function. Not critical as
hopefully no one will write anything stupid to that, but nice to lock
down anyway if you have the time.
Hi Jonathan,
Will add a check for val < 0 || val2 < 0.
If you don't mind I'll target the patch to the out of staging iio folder.
drivers/iio/amplifiers/ad8366.c
Signed-off-by: Michael Hennerich<michael.hennerich@xxxxxxxxxx>
Acked-by: Jonathan Cameron<jic23@xxxxxxxxxx>
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
