On Thu, May 03, 2012 at 12:26:36PM +0200, Johan Hovold wrote: > Add support for National Semiconductor / TI LM3533 lighting power chips. > > This is the core driver which provides register access over I2C and > registers the ambient-light-sensor, LED and backlight sub-drivers. Reviwed-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> though > + dev_dbg(lm3533->dev, "read [%02x]: %02x\n", reg, *val); I'd expect you can drop these log messages, if there's stuff like this missing we should add it to regmap. At the minute the regmap logging is via trace points rather than debug logs as you can leave them enabled all the time. Might also be worth moving some of the sysfs stuff to live with the relevant drivers.
Attachment:
signature.asc
Description: Digital signature
