On 08/26/11 09:43, michael.hennerich@xxxxxxxxxx wrote: > From: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > > Not sure if this is a proper fix. However it should do the trick. > ring->scan_maks is allocated in iio_ring_buffer_register() which called > after adis16400_configure_ring. So the time this pointer dereference takes > place scan_mask is uninitialized. Dratt missed that one. This definitely isn't the right fix as it will get wiped out when that element is initialized. Mostly I fixed equivalents elsewhere by not setting a default. After all user space shouldn't be relying on any particular set of channels being enable anyway. Do we have a good reason to not just remove it here? > > Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > --- > drivers/staging/iio/imu/adis16400_ring.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/iio/imu/adis16400_ring.c b/drivers/staging/iio/imu/adis16400_ring.c > index 1a47d07..f6d50be 100644 > --- a/drivers/staging/iio/imu/adis16400_ring.c > +++ b/drivers/staging/iio/imu/adis16400_ring.c > @@ -191,7 +191,7 @@ int adis16400_configure_ring(struct iio_dev *indio_dev) > ring->setup_ops = &adis16400_ring_setup_ops; > ring->owner = THIS_MODULE; > /* Set default scan mode - assumes single long is big enough */ > - *ring->scan_mask = st->variant->default_scan_mask; > + ring->scan_mask = &st->variant->default_scan_mask; > ring->scan_count = hweight_long(st->variant->default_scan_mask); > > indio_dev->pollfunc = iio_alloc_pollfunc(&iio_pollfunc_store_time, -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
