On 07/26/11 10:01, Hennerich, Michael wrote: > Jonathan Cameron wrote on 2011-07-25: >> Michael pointed out the issues that not having an explicit direction >> for channels was causing and the inconsistency of the inX and outX >> channel naming we got from hmwon. >> >> They are stuck with it, but we aren't, so lets fix this now. >> >> Interesting question is whether we reset the base units to be volts >> whilst we are at it? (for voltage channels obviously!) > > What do you mean exactly volts versus milli volts? Make the in_voltage_scale correspond to conversion to volts instead of millivolts as now (I think). Err. Looking at it that isn't actually documented... oops. I wonder which drivers actually do that and which don't. > Or given the fact that we have some current converter currently as inX and outX - We do? Ouch. In the 'interesting' drivers or in the clean ones? > So we need to audit the datasheet to make sure we the (in|out)_(voltage|current)Y_raw > right? Probably need to audit everything during the move out of staging anyway. It would be far from unusual if we found an off by 1000 error somewhere in he drivers. > > >> Given there will be a lot of auditing and datasheet reading to do >> that, I suggest that if we decide to do it, we leave that for when we >> are moving drivers out of staging. >> >> We could roll the doc patch in with the one in the previous series to >> reduce churn. If they go together I'll probably do that. >> >> Thanks, >> >> Jonathan >> >> Jonathan Cameron (2): >> staging:iio: ABI rework - add in_ or out_ prefix to channnels >> staging:iio:Documentation sysfs-bus-iio add in and out prefixes >> drivers/staging/iio/Documentation/sysfs-bus-iio | 536 >> +++++++++++---- >> ------- >> drivers/staging/iio/dac/ad5686.c | 24 +- >> drivers/staging/iio/iio.h | 31 ++- >> drivers/staging/iio/industrialio-core.c | 28 +- >> 4 files changed, 324 insertions(+), 295 deletions(-) > > Greetings, > Michael > > -- > Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen > Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
