On 07/20/11 13:36, michael.hennerich@xxxxxxxxxx wrote: > From: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > > The AD7280A monitoring system contains all the functions required for > general purpose monitoring and maintenance of stacked > lithium ion batteries as used in hybrid electric vehicles, > battery backup applications, etc. > > Changes since V1: > > Make cell channels all type IIO_IN_DIFF, update documentation accordingly. > Remove unused and redundant defines. > Use SI units where applicable. > Remove unnecessary wrapper function. > Remove redundant initialization. > Add comments where requested. > Revise event handler. > Use const where applicable. > One unnecessary include - adc.h (which is more important given I've removed the file in a set that Greg is sitting on till 3.1-rc1 is out ;) I'm fine with this going faster if Greg wants to take it, it's just that scrapping that include will avoid a merge issue down the line. Otherwise fine by me. > Reviewed-by: Jonathan Cameron <jic23@xxxxxxxxx> > Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> Just for reference, I think your signed-off should always be the top entry. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
