On 07/19/11 15:27, Arnd Bergmann wrote: > On Monday 18 July 2011, Jonathan Cameron wrote: >> 4 uses Arnd's suggestion of an annon_fd obtained via ioctl on the buffer >> chrdev to get a file for easy use for reading events. This is a very neat >> solution that lets us keep the actual event system separate from the data >> stream without two chrdevs. > > IMHO, the series looks good overall, but you need to fix the iio_ioctl > function to take a proper ioctl command: you check for 'cmd == 0', which is > not allowed by convention. > Please use the _IOR() macro to define a number and document the command > range in Documentation/ioctl/ioctl-number.txt. > > Also, you should have a .compat_ioctl file operation that points to > the same function, to make sure that the interface works in 32 bit > processes running on a 64 bit kernel. > > Arnd > Cool. Thanks for those pointers. I hacked that bit in a bit fast without really looking into it.. :) -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
