RE: [PATCH 3/4] staging:iio:imu:adis16400: use strtobool for reset sysfs and don't assign unused tx members.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Cameron wrote on 2011-07-11:
> Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxx>

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
>  drivers/staging/iio/imu/adis16400_core.c |   23 +++++++++++-----------
>  - 1 files changed, 11 insertions(+), 12 deletions(-)
> diff --git a/drivers/staging/iio/imu/adis16400_core.c
> b/drivers/staging/iio/imu/adis16400_core.c index f034330..75d4734 100644
> --- a/drivers/staging/iio/imu/adis16400_core.c +++
> b/drivers/staging/iio/imu/adis16400_core.c @@ -146,8 +146,6 @@ static
> int adis16400_spi_read_reg_16(struct iio_dev *indio_dev,
>       mutex_lock(&st->buf_lock);
>       st->tx[0] = ADIS16400_READ_REG(lower_reg_address);
>       st->tx[1] = 0;
> -     st->tx[2] = 0;
> -     st->tx[3] = 0;
>
>       spi_message_init(&msg);         spi_message_add_tail(&xfers[0], &msg); @@
>  -236,17 +234,18 @@ static ssize_t adis16400_write_reset(struct device
>  *dev,                struct device_attribute *attr,          const char *buf, size_t len) {
> -     struct iio_dev *indio_dev = dev_get_drvdata(dev);
> +     bool val;
> +     int ret;
>
> -     if (len < 1)
> -             return -1;
> -     switch (buf[0]) {
> -     case '1':
> -     case 'y':
> -     case 'Y':
> -             return adis16400_reset(indio_dev);
> -     }
> -     return -1;
> +     ret = strtobool(buf, &val);
> +     if (ret < 0)
> +             return ret;
> +     if (val)
> +             ret = adis16400_reset(dev_get_drvdata(dev));
> +     if (ret < 0)
> +             return ret;
> +
> +     return len;
>  }
>
>  int adis16400_set_irq(struct iio_dev *indio_dev, bool enable)

Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux