On 06/21/11 23:54, Bryan Freed wrote: > Add the required read/write_raw functions to the tsl2563_info_no_irq data > structure. This structure is used insted of tsl2563_info when the I2C client > has no IRQ. > The absence of these functions causes a panic when reading or writing the > created sysfs files. Yikes. Good spot. I'd completely forgotten that no_irq version was there. Greg, please pick these two up as fixes. Sorry for the rubbish conversion in the first place! > > Signed-off-by: Bryan Freed <bfreed@xxxxxxxxxxxx> Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> > --- > drivers/staging/iio/light/tsl2563.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c > index d9be19c..bca99f1 100644 > --- a/drivers/staging/iio/light/tsl2563.c > +++ b/drivers/staging/iio/light/tsl2563.c > @@ -713,6 +713,8 @@ static struct i2c_driver tsl2563_i2c_driver; > > static const struct iio_info tsl2563_info_no_irq = { > .driver_module = THIS_MODULE, > + .read_raw = &tsl2563_read_raw, > + .write_raw = &tsl2563_write_raw, > }; > > static const struct iio_info tsl2563_info = { -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html