On 05/04/11 14:33, Arnd Bergmann wrote: > On Wednesday 04 May 2011, Jonathan Cameron wrote: >> First to Arnd: Obviously I'm not expecting you to review this >> 'little' set. I just wanted to keep you in the loop on what happened >> with your suggestions. >> > > Thanks for the update, this looks like excellent progress! > > I've briefly looked over most of the patches and they all look good > to me, I especially like the total diffstat of > 112 files changed, 7402 insertions(+), 12638 deletions(-) The stats cheat a bit as I combined 3 of the big drivers into one in the middle of the set. Still, a general downward trend with no loss of functionality is always nice ;) > > One of the main problems we discussed earlier is the chardev interface > with its event handling, and I think you got it exactly right now, but > I'm not completely sure if I understand correctly what you do there, > so maybe you can explain how it works with the new buffer device. There are still some corners to be ironed out. It's better than it was - but we still need to look at the issue of blocking reads. > > Ideally, that could be in man-page style so it can go into section 4 of > the man pages, /usr/share/man/man4/iio.4. Good idea. I'll add it to the todo list. Right now pretty much all the docs we have in tree are way out of date, so that's next on my list. Thanks for your time looking at this. It has been very helpful indeed. Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
