Jonathan Cameron wrote on 2011-04-15: > On 04/14/11 13:26, michael.hennerich@xxxxxxxxxx wrote: >> From: Michael Hennerich <michael.hennerich@xxxxxxxxxx> >> > Yikes. That union stuff for the transfers is ugly. Having said that I > can't immediately see a better way of doing it. > Otherwise another nice clean an easy to read driver. Thanks, I don't > think I've overly broken anything in here with the recent changes. > The only acception is adding a 0 parameter to iio_allocate_device. > > That kind of depends on when Greg picks up the last set I sent him. > > The other cleanup that applies here is to set indio_dev->name and get > rid of the explicit name attribute. Can do that one later though as > it will still work as is. Just saves a few lines of code. I've sent Greg the driver. Hope he gets the ordering right on how this one interferes with your [PATCH 4/8] set. As for you your [PATCH x/70] set feel free to add my Acked-by on the relevant patches. How do you want to handle these? When do you want to send it on to Greg? In case you want to wait for a few days, I test a few devices and send you some patches, that moves the missing ones over to the new channel registration method. I'll do that on top of your todays iio-onwards. >> >> Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
