On 2/21/25 10:54, Niklas Cassel wrote: > atapi_eh_request_sense() currently uses ATAPI DMA if the SATA controller > has ATA_FLAG_PIO_DMA (PIO cmds via DMA) set. > > However, ATA_FLAG_PIO_DMA is a flag that can be set by a low-level driver > on a port at initialization time, before any devices are scanned. > > If a controller detects a connected device that only supports PIO, we set > the flag ATA_DFLAG_PIO. > > Modify atapi_eh_request_sense() to not use ATAPI DMA if the connected > device only supports PIO. > > Reported-by: Philip Pemberton <lists@xxxxxxxxxxxxx> > Closes: https://lore.kernel.org/linux-ide/c6722ee8-5e21-4169-af59-cbbae9edc02f@xxxxxxxxxxxxx/ > Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx> Looks good. Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx> -- Damien Le Moal Western Digital Research