On 2/20/25 5:35 AM, Salah Triki wrote: > Remove hard-coded strings by using the str_up_down() helper function. > > Signed-off-by: Salah Triki <salah.triki@xxxxxxxxx> This looks OK but the patch title should be: ata: sata_via: Use str_up_down() helper in vt6420_prereset() With that fixed, Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx> -- Damien Le Moal Western Digital Research