Hi Raphael, On Mon, 27 Jan 2025 at 13:46, Raphael Gallais-Pou <rgallaispou@xxxxxxxxx> wrote: > Several AHCI drivers expose suspend/resume functions in a way that can > be simplified. Using pre-processor operation can lead to errors, while > relying on automatic kernel configuration is safer. It also shrinks the > kernel size when CONFIG_PM_SLEEP is not used[1]. m68k/allyesconfig: drivers/ata/sata_highbank.c: In function ‘ahci_highbank_suspend’: drivers/ata/sata_highbank.c:590:9: error: implicit declaration of function ‘ata_host_suspend’; did you mean ‘ata_sas_port_suspend’? [-Werror=implicit-function-declaration] drivers/ata/sata_highbank.c: In function ‘ahci_highbank_resume’: drivers/ata/sata_highbank.c:607:9: error: implicit declaration of function ‘ata_host_resume’; did you mean ‘ahci_port_resume’? [-Werror=implicit-function-declaration] drivers/ata/pata_arasan_cf.c: In function ‘arasan_cf_suspend’: drivers/ata/pata_arasan_cf.c:938:9: error: implicit declaration of function ‘ata_host_suspend’; did you mean ‘ata_sas_port_suspend’? [-Werror=implicit-function-declaration] drivers/ata/pata_arasan_cf.c: In function ‘arasan_cf_resume’: drivers/ata/pata_arasan_cf.c:948:9: error: implicit declaration of function ‘ata_host_resume’; did you mean ‘sata_link_resume’? [-Werror=implicit-function-declaration] drivers/ata/sata_rcar.c: In function ‘sata_rcar_suspend’: drivers/ata/sata_rcar.c:936:9: error: implicit declaration of function ‘ata_host_suspend’; did you mean ‘sata_rcar_suspend’? [-Werror=implicit-function-declaration] drivers/ata/sata_rcar.c: In function ‘sata_rcar_resume’: drivers/ata/sata_rcar.c:973:9: error: implicit declaration of function ‘ata_host_resume’; did you mean ‘sata_rcar_resume’? [-Werror=implicit-function-declaration] drivers/ata/pata_imx.c: In function ‘pata_imx_suspend’: drivers/ata/pata_imx.c:209:9: error: implicit declaration of function ‘ata_host_suspend’; did you mean ‘pata_imx_suspend’? [-Werror=implicit-function-declaration] drivers/ata/pata_imx.c: In function ‘pata_imx_resume’: drivers/ata/pata_imx.c:232:9: error: implicit declaration of function ‘ata_host_resume’; did you mean ‘pata_imx_resume’? [-Werror=implicit-function-declaration] Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds