Hello Daniel,
On Sat, Jan 18, 2025 at 06:52:30AM +0100, Daniel Baumann wrote:
> Hi,
>
> since the kernel enabled LPM by default, Samsung 870 QVO SATA SSDs don't
> work anymore. Disabling LPM for them solves it, please consider applying
> the attached patch.
>
> I've added a new case for 870 QVO specifically as regular 870 don't have
> the issue.
This should have been in the commit message.
Out of curiosity, did you test on regular 870, so you know they are not
broken as well?
>
> [I'm not subscribed to the list, please CC on replies]
>
> Regards,
> Daniel
> From 55e2cb12faa48cf429ad4a299ea4e4a3a9ba25f5 Mon Sep 17 00:00:00 2001
> From: Daniel Baumann <daniel@xxxxxxxxxx>
> Date: Sat, 18 Jan 2025 06:36:43 +0100
> Subject: [PATCH] Disabling link power-management on Samsung SSD 870 QVO drives
> to make them work.
The subject should be something like:
ata: libata-core: Add ATA_QUIRK_NOLPM for Samsung SSD 870 QVO drives
>
> Signed-off-by: Daniel Baumann <daniel@xxxxxxxxxx>
You probably also want to add:
Fixes: 7627a0edef54 ("ata: ahci: Drop low power policy board type")
Cc: stable@xxxxxxxxxxxxxxx
> ---
> drivers/ata/libata-core.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index c085dd81ebe7..63ec2f218431 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4143,6 +4143,10 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
> { "Samsung SSD 860*", NULL, ATA_QUIRK_NO_NCQ_TRIM |
> ATA_QUIRK_ZERO_AFTER_TRIM |
> ATA_QUIRK_NO_NCQ_ON_ATI },
> + { "Samsung SSD 870 QVO*", NULL, ATA_QUIRK_NO_NCQ_TRIM |
> + ATA_QUIRK_ZERO_AFTER_TRIM |
> + ATA_QUIRK_NO_NCQ_ON_ATI |
> + ATA_QUIRK_NOLPM },
> { "Samsung SSD 870*", NULL, ATA_QUIRK_NO_NCQ_TRIM |
> ATA_QUIRK_ZERO_AFTER_TRIM |
> ATA_QUIRK_NO_NCQ_ON_ATI },
> --
> 2.45.2
>
