* Linus Walleij (linus.walleij@xxxxxxxxxx) wrote: > On Wed, Dec 11, 2024 at 2:12 AM <linux@xxxxxxxxxxx> wrote: > > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx> > > > > gemini_sata_reset_bridge() was added in 2017 by the initial > > commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010") > > but has never been used. > > > > Remove it. > > > > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx> > > Right it was never used because the corresponding reset in > the low-level PATA driver didn't work so I patched it out before > submitting. Ah right. > But should you not also remove sata0_reset and > sata1_reset from struct sata_gemini and the code fetching > the two reset lines? And even #include <linux/reset.h>? Oh I see, I was just looking for entirely unreferenced functions but that takes a little more following to notice. I'm happy to do that; are you OK with it as a follow up patch or do you want a v2? (And can you test it, I don't have the hardware). Dave > Yours, > Linus Walleij -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/