Re: [PATCH 1/6] ata: acard-ahci: use dev_info() instead of, printk(KERN_INFO)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/8/24 21:16, Sergey Shtylyov wrote:
The ACard AHCI PCI device driver still calls printk(KERN_INFO, ...) in its
probe() method -- convert it to calling dev_info(), also somewhat rewording
the message itself...

This helpfully fixes the following complaint from scripts/checkpatch.pl:

WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...

Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

---
  drivers/ata/acard-ahci.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/acard-ahci.c b/drivers/ata/acard-ahci.c
index 547f56341705..0e16e64d1c5d 100644
--- a/drivers/ata/acard-ahci.c
+++ b/drivers/ata/acard-ahci.c
@@ -415,7 +415,7 @@ static int acard_ahci_init_one(struct pci_dev *pdev, const struct pci_device_id
  	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
  		host->flags |= ATA_HOST_PARALLEL_SCAN;
  	else
-		printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n");
+		dev_info(&pdev->dev, "AHCI SSS flag set, parallel bus scan disabled\n");
for (i = 0; i < host->n_ports; i++) {
  		struct ata_port *ap = host->ports[i];

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux