On Wed, Sep 11, 2024 at 08:14:32PM +0300, Sergey Shtylyov wrote: > On 9/11/24 1:22 AM, Damien Le Moal wrote: > > > > Maybe rename the option to CONFIG_PATA_TOSHIBA_PICCCOLO ? > > Nah, that doesn't make much sense to me; if we rename it, we should match the driver's name, i.e. make it CONFIG_PATA_PICCOLO. I'm mainly concerned about the > Linux distros which would have to handle such rename somehow, IIUC... I still remember: 4dd4d3deb502 ("ata: ahci: Rename CONFIG_SATA_LPM_MOBILE_POLICY configuration item") and 55b014159ee7 ("ata: ahci: Rename CONFIG_SATA_LPM_POLICY configuration item back") so I also prefer to avoid renaming Kconfigs as far as possible. Kind regards, Niklas