Re: [PATCH v2] ata: libata: Add helper ata_eh_decide_disposition()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/28/24 16:27, Niklas Cassel wrote:
> Every time I see libata code calling scsi_check_sense(), I get confused
> why the code path that is working fine for SCSI code, is not sufficient
> for libata code.
> 
> The reason is that SCSI usually gets the sense data as part of the
> completion, and will thus automatically call scsi_check_sense(), which
> will set the SCSI ML byte (if any).
> 
> However, for libata queued commands, we always need to fetch the sense
> data via SCSI EH, and thus do not get the luxury of having
> scsi_check_sense() called automatically.
> 
> Add a new helper, ata_eh_decide_disposition(), that has a ata_eh_ prefix
> to more clearly highlight that this is only needed for code called by EH,
> while also having a similar name to scsi_decide_disposition(), such that
> it is easier to compare the libata code with the equivalent SCSI code.
> 
> Also add a big kdoc comment explaining why this helper is called/needed in
> the first place.
> 
> Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx>

Applied to for-6.12. Thanks !

-- 
Damien Le Moal
Western Digital Research





[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux