On Mon, Aug 26, 2024 at 04:31:04PM +0900, Damien Le Moal wrote: > The function ata_eh_read_sense_success_ncq_log() does more that just > reading the sense data for successful NCQ commands log page as it also > sets the sense data for all commands listed in the log page. > > Rename this function to ata_eh_get_ncq_success_sense() to better > describe what the function does. Furthermore, since this function is > only called from ata_eh_get_success_sense() in libata-eh.c, there is no > need to export it and its declaration can be moved to > drivers/ata/libata.h. > > To be consistent with this change, the function > ata_eh_read_sense_success_non_ncq() is also renamed to > ata_eh_get_non_ncq_success_sense(). > > Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx> > --- Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>
