From: Zheng Qixing <zhengqixing@xxxxxxxxxx> In ata_host_alloc(), if ata_port_alloc(host) fails to allocate memory for a port, the allocated 'host' structure is not freed before returning from the function. This results in a potential memory leak. This patch adds a kfree(host) before the error handling code is executed to ensure that the 'host' structure is properly freed in case of an allocation failure. Signed-off-by: Zheng Qixing <zhengqixing@xxxxxxxxxx> --- Changes in v2: - error path is wrong in v1 drivers/ata/libata-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index e4023fc288ac..f27a18990c38 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5663,8 +5663,10 @@ struct ata_host *ata_host_alloc(struct device *dev, int n_ports) } dr = devres_alloc(ata_devres_release, 0, GFP_KERNEL); - if (!dr) + if (!dr) { + kfree(host); goto err_out; + } devres_add(dev, dr); dev_set_drvdata(dev, host); -- 2.39.2