On 7/23/24 09:28, Robin H. Johnson wrote: > On Tue, Jul 23, 2024 at 08:10:01AM +0900, Damien Le Moal wrote: >>> >>> Should this check be '__ATA_HORKAGE_MAX > 32'? >>> >>> When __ATA_HORKAGE_MAX is 32 then the last horkage bit will be 31. > Do we need to save that last bit for a future expansion? ATA_HORKAGE2? I do not think so. When/if we end up adding horkage bits beyond 32, we can simply convert from an unsigned int to an u64 or a bitfield (bitmap). -- Damien Le Moal Western Digital Research
