On Fri, Jul 12, 2024 at 04:59:38PM -0400, Frank Li wrote: > On Fri, Jul 12, 2024 at 10:52:39PM +0200, Niklas Cassel wrote: > > On Fri, Jul 12, 2024 at 02:57:40PM -0400, Frank Li wrote: > > > Add missing documented compatible strings 'fsl,ls1046a-ahci' and > > > 'fsl,ls1012a-ahci'. Allow 'fsl,ls1012a-ahci' to fallback to > > > 'fsl,ls1043a-ahci'. > > > > > > Fix below CHECK_DTB warnings > > > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible:0: 'fsl,ls1012a-ahci' is not one of ['fsl,ls1021a-ahci', 'fsl,ls1043a-ahci', 'fsl,ls1028a-ahci', 'fsl,ls1088a-ahci', 'fsl,ls2080a-ahci', 'fsl,lx2160a-ahci'] > > > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible: ['fsl,ls1012a-ahci', 'fsl,ls1043a-ahci'] is too long > > > > These lines should have been wrapped to 75 lines IMO. > > I will fixup when applying. > > Thanks, according to my knowledge, computer generate warning, error, log... > doesn't require wrap. Yes, that is correct, especially for critical things like a kernel oops etc. In this case, I don't think a simple CHECK_DTB warning is critical enough to warrant keeping a line length of 232 columns, but I agree that 'critical enough' is subjective. Kind regards, Niklas
