On Thu, Jun 27, 2024 at 10:37:40AM +0900, Damien Le Moal wrote: > On 6/27/24 03:00, Niklas Cassel wrote: > > Currently, the ata_port print_ids are increased indefinitely, even when > > there are lower ids available. > > > > E.g. on first boot you will have ata1-ata6 assigned. > > After a rmmod + modprobe, you will instead have ata7-ata12 assigned. > > > > Move to use the ida_alloc() API, such that print_ids will get reused. > > This means that even after a rmmod + modprobe, the ports will be assigned > > print_ids ata1-ata6. > > > > Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx> > > Looks good. But maybe it would make sense to squash this together with patch 10 ? Patch 10 initializes the print_ids earlier (which is a perfectly fine change on its own, even with the old way to assign print_ids), while this patch changes for the print_ids to be reusable. I think that logically, it is two different logical changes so I will keep them as separate patches in v3. Kind regards, Niklas
