On Sun, Jun 30, 2024 at 02:40:07PM -0700, Linus Torvalds wrote: > On Sun, 30 Jun 2024 at 14:28, Niklas Cassel <cassel@xxxxxxxxxx> wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux tags/ata-6.10-rc6 > > So I've pulled these, but I'm not happy with how they seem to be _very_ recent. > > Yes, they all look trivial, but even trivial commits have bugs, and it > looks like they have had absolutely zero testing. Four out of five > commits were committed about an hour ago. The four out of five patches were originally part of a larger series, sent out on Wednesday: https://lore.kernel.org/linux-ide/20240626180031.4050226-15-cassel@xxxxxxxxxx/ They have been tested using: rmmod + modprobe + rmmod + modprobe on: -AMD AHCI controller -QEMU AHCI controller -pm8001 SAS (libsas) controller Both with a debug patch that forced an error, and without any additional debug patch. Ensuring that: -The error/crash was fixed (in case of forced error) -That all devices show up as intended (in case of no forced error) So it probably looks worse than it is. > So please - don't do this. I was close to just unpulling it all again, > and if this had been some final -rc, that's what I would have done. > This kind of "last-minute commits in last-minute pull request" is not > ok. Understood! FWIW, even with the testing done, I would never even have considered doing the same if we were later in the release cycle. Kind regards, Niklas
