On Thu, Jun 27, 2024 at 01:26:04PM +0100, John Garry wrote: > On 26/06/2024 19:00, Niklas Cassel wrote: > > Hello all, > > > > This patch series was orginally meant to simply assign a unique id used > > for printing earlier (ap->print_id), but has since grown to also include > > cleanups related to ata_port_alloc() (since ap->print_id is now assigned > > in ata_port_alloc()). > > > > There's no real problem statement wrt print_id, telling how and why things > are like they are, how it is a problem, and how it is improved in this > series. You are right, it is missing from the cover-letter. It was there in v1: https://lore.kernel.org/linux-ide/20240618153537.2687621-7-cassel@xxxxxxxxxx/ """ This series moves the assignment of ap->print_id, which is used as a unique id for each port, earlier, such that we can use the ata_port_* print functions even before the ata_host has been registered. """ Will re-add it in v3. Kind regards, Niklas