Re: [PATCH 6/7] block: remove the fallback case in queue_dma_alignment

[John Garry <john.g.garry@xxxxxxxxxx>]

On 25/06/2024 12:05, Christoph Hellwig wrote:
> Now that all updates go through blk_validate_limits the default of 511
> is set at initialization time.

The code handles q == NULL case, so is q == NULL now impossible?

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>   include/linux/blkdev.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index e23fc418bb2260..d93fba7a1f3162 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1393,7 +1393,7 @@ static inline bool bdev_is_zone_start(struct block_device *bdev,
>   
>   static inline int queue_dma_alignment(const struct request_queue *q)
>   {
> -	return q ? q->limits.dma_alignment : 511;
> +	return q->limits.dma_alignment;
>   }
>   
>   static inline unsigned int