On Thu, Jun 13, 2024 at 10:00:30PM +0300, Sergei Shtylyov wrote: > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > > index cdf29b178ddc..e231ad22f88a 100644 > > --- a/drivers/ata/libata-scsi.c > > +++ b/drivers/ata/libata-scsi.c > > @@ -1831,11 +1831,11 @@ static unsigned int ata_scsiop_inq_std(struct ata_scsi_args *args, u8 *rbuf) > > 2 > > }; > > > > - /* set scsi removable (RMB) bit per ata bit, or if the > > - * AHCI port says it's external (Hotplug-capable, eSATA). > > + /* > > + * Set the SCSI Removable Media Bit (RMB) if the ATA removable media > > + * device bit (which is only defined in the CFA specification) is set. > > It used to be defined since ATA-1; I think it was only obsoleted by ATA-8 ACS... Looking at the t13 achives, it was obsoleted by: e06116r0: Obsolete removable media related feature sets in 2006, ATA-8 ACS (i.e. ACS-1). I will update the comment accordingly and send out a v2. Kind regards, Niklas
