On Thu, Apr 04, 2024 at 09:55:13AM -0700, Bart Van Assche wrote:
> On 4/2/24 06:06, Christoph Hellwig wrote:
>> diff --git a/drivers/scsi/mpi3mr/mpi3mr_app.c b/drivers/scsi/mpi3mr/mpi3mr_app.c
>> index ce5445eb9d0e4e..05e061fc6d3a06 100644
>> --- a/drivers/scsi/mpi3mr/mpi3mr_app.c
>> +++ b/drivers/scsi/mpi3mr/mpi3mr_app.c
>> @@ -1838,6 +1838,10 @@ void mpi3mr_bsg_init(struct mpi3mr_ioc *mrioc)
>> {
>> struct device *bsg_dev = &mrioc->bsg_dev;
>> struct device *parent = &mrioc->shost->shost_gendev;
>> + struct queue_limits lim = {
>> + .max_hw_sectors = MPI3MR_MAX_APP_XFER_SECTORS,
>> + .max_segments = MPI3MR_MAX_APP_XFER_SEGMENTS,
>> + };
>
> Can 'lim' be declared 'static const'?
It can't because the queue limit validation can modify it (and thus
none of the pointers in the chain leading to it are marked const)
