Re: [PATCH 01/23] block: add a helper to cancel atomic queue limit updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 03/04/2024 13:51, Christoph Hellwig wrote:
On Wed, Apr 03, 2024 at 08:38:42AM +0100, John Garry wrote:
+ */
+static inline void queue_limits_cancel_update(struct request_queue *q)

Just curious, why no __releases() annotation, like what we have in

Mostly because sparse doesn't seem to actually need it on inline
functins.  At least I don't seem to get a sparse warning without it.

JFYI, I am noticing this on v6.9-rc2 with vanilla defconfig:

john@localhost:~/mnt_sda4/john/linux> make C=1 block/blk-settings.o
 UPD     include/config/kernel.release
 UPD     include/generated/utsrelease.h
 CALL    scripts/
 DESCEND objtool
 INSTALL libsubcmd_headers
 CC      block/blk-settings.o
 CHECK   block/blk-settings.c
block/blk-settings.c:263:9: warning: context imbalance in
'queue_limits_commit_update' - wrong count at exit

Is that a known issue?

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux